Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: fix float over flow when converting a decimal to a float and then converting a float to an uint (#10405) #10730

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jun 6, 2019

cherry-pick for #10405.

zz-jason
zz-jason previously approved these changes Jun 6, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

zz-jason commented Jun 6, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 6, 2019
@qw4990 qw4990 requested review from alivxxx and XuHuaiyu June 6, 2019 02:35
@qw4990
Copy link
Contributor Author

qw4990 commented Jun 6, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit d07bdb2 into pingcap:release-2.1 Jun 6, 2019
@qw4990 qw4990 changed the title type: fix float over flow when converting a decimal to a float and then converting a float to an uint type: fix float over flow when converting a decimal to a float and then converting a float to an uint (#10405) Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants