config: fix 'PessimisticTxn' config JSON key #10820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonng <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #10820 +/- ##
================================================
+ Coverage 80.2889% 80.2901% +0.0011%
================================================
Files 417 417
Lines 88453 88453
================================================
+ Hits 71018 71019 +1
+ Misses 12231 12226 -5
- Partials 5204 5208 +4 |
Codecov Report
@@ Coverage Diff @@
## master #10820 +/- ##
================================================
- Coverage 80.2878% 80.2776% -0.0102%
================================================
Files 417 417
Lines 88453 88453
================================================
- Hits 71017 71008 -9
- Misses 12230 12238 +8
- Partials 5206 5207 +1 |
|
@coocood PTAL |
|
/run-all-tests |
zimulala
reviewed
Jun 17, 2019
| @@ -82,7 +82,7 @@ type Config struct { | |||
| Binlog Binlog `toml:"binlog" json:"binlog"` | |||
| CompatibleKillQuery bool `toml:"compatible-kill-query" json:"compatible-kill-query"` | |||
| Plugin Plugin `toml:"plugin" json:"plugin"` | |||
| PessimisticTxn PessimisticTxn `toml:"pessimistic-txn" json:"pessimistic_txn"` | |||
| PessimisticTxn PessimisticTxn `toml:"pessimistic-txn" json:"pessimistic-txn"` | |||
There was a problem hiding this comment.
Could we add test for it？
There was a problem hiding this comment.
OK, I will add some tests later.
|
/run-unit-test |
|
LGTM |
winkyao
pushed a commit
that referenced
this pull request
Jun 18, 2019
Signed-off-by: Lonng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lonng [email protected]
What problem does this PR solve?
This PR fix 'PessimisticTxn' config JSON key