Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: enable function any_value in aggregation if ONLY_FULL_GROUP_BY is set (#9255) #10994

Merged
merged 3 commits into from
Jul 3, 2019
Merged

planner: enable function any_value in aggregation if ONLY_FULL_GROUP_BY is set (#9255) #10994

merged 3 commits into from
Jul 3, 2019

Conversation

XuHuaiyu
Copy link
Contributor

@XuHuaiyu XuHuaiyu commented Jul 1, 2019

cherry-pick #9255

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Jul 1, 2019
jackysp
jackysp reviewed Jul 1, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 1, 2019
@XuHuaiyu XuHuaiyu requested a review from qw4990 July 1, 2019 07:32
zz-jason
zz-jason approved these changes Jul 1, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 1, 2019
@zz-jason
Copy link
Member

zz-jason commented Jul 1, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Jul 1, 2019
@XuHuaiyu
Copy link
Contributor Author

XuHuaiyu commented Jul 3, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@zz-jason zz-jason merged commit 308488c into pingcap:release-2.1 Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zz-jason zz-jason zz-jason approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @zz-jason @jackysp @spongedu