Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: disable trace statement #11039

Merged
merged 2 commits into from
Jul 3, 2019

Conversation

tiancaiamao
Copy link
Contributor

trace is not a completed feature in the 2.1 branches.
Disable it to avoid panic:

    mysql> trace select * from user limit 1;
    ERROR 2006 (HY000): MySQL server has gone away

trace is not a completed feature in 2.1 branch.
Disable it to avoid panic:
    mysql> trace select * from user limit 1;
    ERROR 2006 (HY000): MySQL server has gone away
@tiancaiamao tiancaiamao added priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution labels Jul 2, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @zimulala @jackysp

@mahjonp
Copy link
Contributor

mahjonp commented Jul 2, 2019

/rebuild

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Jul 3, 2019

/run-all-tests tikv=release-2.1 tidb-test=release-2.1 pd=release-2.1

@winkyao winkyao merged commit c9a7dba into pingcap:release-2.1 Jul 3, 2019
@tiancaiamao tiancaiamao deleted the disable-trace branch July 3, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants