Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: fix the issue that the length of the index is 0. #11045

Merged
merged 3 commits into from
Jul 8, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jul 3, 2019

What problem does this PR solve?

Fix #10644

What is changed and how it works?

Add the type check when the length of the index is 0.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@zimulala
Copy link
Contributor Author

zimulala commented Jul 3, 2019

/run-all-tests

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #11045 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #11045   +/-   ##
=========================================
  Coverage   81.124%   81.124%           
=========================================
  Files          420       420           
  Lines        89622     89622           
=========================================
  Hits         72705     72705           
  Misses       11657     11657           
  Partials      5260      5260

ddl/index.go Show resolved Hide resolved
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 3, 2019
@zimulala
Copy link
Contributor Author

zimulala commented Jul 5, 2019

PTAL @bb7133 @crazycs520

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The used storage engine can't index column ‘xxxx’
5 participants