executor: compute ADMIN CHECKSUM for partitioned tables correctly #11089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytm
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #11089 +/- ##
===============================================
- Coverage 81.222% 81.0032% -0.2188%
===============================================
Files 420 419 -1
Lines 90031 89347 -684
===============================================
- Hits 73125 72374 -751
- Misses 11675 11729 +54
- Partials 5231 5244 +13 |
Codecov Report
@@ Coverage Diff @@
## master #11089 +/- ##
===========================================
Coverage 81.7694% 81.7694%
===========================================
Files 423 423
Lines 91928 91928
===========================================
Hits 75169 75169
Misses 11458 11458
Partials 5301 5301 |
|
PTAL @lamxTyler (I'm not sure what happened with the coverage 😕) |
alivxxx
reviewed
Jul 5, 2019
| } | ||
|
|
||
| reqs := make([]*kv.Request, 0, (len(c.TableInfo.Indices)+1)*(len(partDefs)+1)) | ||
| if err := c.appendRequest(ctx, c.TableInfo.ID, &reqs); err != nil { |
There was a problem hiding this comment.
Can we save the request to the table when it is a partitioned table since it won't have any data?
There was a problem hiding this comment.
Yes we could (add an if clause), but since the range contains no data I think the overhead would be small. OTOH if we do want to support global index, I suppose those indices will be placed in the table itself, so we still need to appendRequest(c.TableInfo.ID).
|
PTAL @winkyao |
|
😐 PTAL @zz-jason |
|
/run-all-tests |
zz-jason
added
status/LGT2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10796. The ADMIN CHECKSUM TABLE of a partition table was not computed correctly since the actual data and indices are stored in the child physical tables (the partitions).
What is changed and how it works?
If a table has partitions, push the checksum requests for those tables too.
Check List
Tests
Code changes
Side effects
Related changes