Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: fix data race of rand function (#11168) #11169

Merged
merged 1 commit into from
Jul 11, 2019
Merged

expression: fix data race of rand function (#11168) #11169

merged 1 commit into from
Jul 11, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jul 10, 2019

Cherry pick #11168
No conflicts.

@alivxxx alivxxx requested review from winkyao and winoros July 10, 2019 09:50
winoros
winoros reviewed Jul 10, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

eurekaka
eurekaka approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 11, 2019
@alivxxx
Copy link
Contributor Author

alivxxx commented Jul 11, 2019

/run-all-tests

@ngaut ngaut merged commit d1848b0 into pingcap:release-3.0 Jul 11, 2019
@alivxxx alivxxx deleted the data-race branch July 11, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros left review comments

@eurekaka eurekaka eurekaka approved these changes

@winkyao winkyao Awaiting requested review from winkyao

Assignees
No one assigned
Labels
component/expression status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alivxxx @eurekaka @winoros @ngaut