Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: set the correct stmtCtx for explain statement #11186

Merged
merged 13 commits into from
Aug 27, 2019

Conversation

XuHuaiyu
Copy link
Contributor

What problem does this PR solve?

Fix #11124

What is changed and how it works?

Check the statement type of a explain statement, and set the correct stmtCtx for it.

Check List

Tests

  • Integration test
    TO BE ADDED.

Code changes

  • Has exported function/method change

Side effects

N/A

Related changes

  • Need to cherry-pick to the release branch

@XuHuaiyu XuHuaiyu added type/bugfix This PR fixes a bug. sig/execution SIG execution needs-cherry-pick-2.1 labels Jul 11, 2019
@XuHuaiyu
Copy link
Contributor Author

WAIT FOR #11102

@zz-jason
Copy link
Member

zz-jason commented Aug 3, 2019

@XuHuaiyu #11105 is fixed. Please update to the master branch and resolve conflicts.

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix CI..

executor/executor.go Outdated Show resolved Hide resolved
@zz-jason
Copy link
Member

@XuHuaiyu Friendly ping, any update?

@XuHuaiyu
Copy link
Contributor Author

/run-all-tests

@XuHuaiyu
Copy link
Contributor Author

Ready to be reviewed. @zz-jason @qw4990 @SunRunAway @wshwsh12

@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #11186 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #11186   +/-   ##
=========================================
  Coverage   81.281%   81.281%           
=========================================
  Files          438       438           
  Lines        94685     94685           
=========================================
  Hits         76961     76961           
  Misses       12226     12226           
  Partials      5498      5498

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 27, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 27, 2019

@XuHuaiyu merge failed.

@XuHuaiyu
Copy link
Contributor Author

/run-unit-test

@XuHuaiyu
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Aug 27, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 27, 2019

cherry pick to release-2.1 failed

@XuHuaiyu XuHuaiyu deleted the explain_ctx branch August 27, 2019 06:12
@sre-bot
Copy link
Contributor

sre-bot commented Aug 27, 2019

cherry pick to release-3.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

actual plan of a running stmt is not the same as the result of explain stmt
5 participants