-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor, privilege: fix some two bug of RBAC #11273
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/bugfix
This PR fixes a bug.
sig/execution
SIG execution
component/privilege
needs-cherry-pick-3.0
labels
Jul 16, 2019
Codecov Report
@@ Coverage Diff @@
## master #11273 +/- ##
===========================================
Coverage 81.2607% 81.2607%
===========================================
Files 423 423
Lines 90233 90233
===========================================
Hits 73324 73324
Misses 11607 11607
Partials 5302 5302 |
/run-all-tests tidb-test=pr/847 |
/run-common-test tidb-test=pr/847 |
/run-common-test |
/run-all-tests |
LGTM |
jackysp
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cherry pick to release-3.0 in PR #11356 |
zz-jason
pushed a commit
that referenced
this pull request
Jul 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/privilege
sig/execution
SIG execution
status/LGT1
Indicates that a PR has LGTM 1.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix two bug of RBAC.
bug 1:
CURRENT_ROLE
is not handle correctly inGRANT ROLE
bug 2:
REVOKE ROLE
doesn't delete information inmysql.default_role
What is changed and how it works?
CURRENT_USER
inGrantRoleExec
, ifUser
isCURRENT_USER
, it will be set to current user.mysql.default_role
inRevokeRoleStmt
.Check List
Tests
Code changes
Side effects
Related changes