-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: fix microseconds behaviour in DATE_ADD() #11280
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11280 +/- ##
===============================================
+ Coverage 81.3302% 81.4762% +0.146%
===============================================
Files 423 423
Lines 90344 90689 +345
===============================================
+ Hits 73477 73890 +413
+ Misses 11554 11499 -55
+ Partials 5313 5300 -13 |
SunRunAway
reviewed
Jul 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XuHuaiyu
approved these changes
Jul 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wshwsh12
added a commit
to wshwsh12/tidb
that referenced
this pull request
Jul 17, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jul 17, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#11257
Before the pr:
This pr:
What is changed and how it works?
When using
parseTimeValue
function to get microseconds from string, It will use funcalignFrac
to generate alignment frac.Before this pr, the func hasn't consider the possible that the beginning of the string is a '-'.
e.g.
123
->123000
,-123
->-12300
(the '-' occupy a space)This pr, fix the logic of the function. If the string is started with a '-', do a special treatment.
-123
->-123000
Check List
Tests
Code changes
Side effects
Related changes