expression: let testEvaluatorSuite run serially to avoid affect other unit tests since it uses failpoint
#11310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11310 +/- ##
===========================================
Coverage 81.2469% 81.2469%
===========================================
Files 423 423
Lines 90156 90156
===========================================
Hits 73249 73249
Misses 11598 11598
Partials 5309 5309 |
|
/run-all-tests |
|
@XuHuaiyu I rebased this PR to the latest Master, so please help me to approve it again~ |
zz-jason
changed the title
testEvaluatorSuite run serially to avoid affect other unit tests since it uses failpointtestEvaluatorSuite run serially to avoid affect other unit tests since it uses failpoint
|
do we need to cherry pick this PR to release 3.0 or 2.1? |
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Jul 22, 2019
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Jul 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Some unit tests of
testEvaluatorSuiteusefailpointto control whether to push down some expressions.Therefore, when it runs parallelly with other unit tests, all other tests will also be affected by this
failpoint, which is undesired.What is changed and how it works?
Let it run serially to avoid affect other unit tests.