Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function SUBTIME ADDTIME should return NULL with a warning if its argument is an invalid time value. (#11262) #11337

Merged
merged 5 commits into from
Jul 23, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Jul 19, 2019

cherry-pick #11262 to release-3.0

@sre-bot
Copy link
Contributor Author

sre-bot commented Jul 19, 2019

/run-all-tests

@SunRunAway
Copy link
Contributor

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2019
@zz-jason
Copy link
Member

/run-all-tests

@lzmhhh123 lzmhhh123 added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2019
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zz-jason zz-jason merged commit e6372f5 into pingcap:release-3.0 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants