Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: fix bugs and make it more effective in outer join elimination rule. (#11160) #11377

Merged
merged 23 commits into from
Jul 29, 2019
Merged

planner: fix bugs and make it more effective in outer join elimination rule. (#11160) #11377

merged 23 commits into from
Jul 29, 2019

Conversation

lzmhhh123
Copy link
Contributor

@lzmhhh123 lzmhhh123 commented Jul 23, 2019 •
edited
Loading

Automated cherry pick of #11160 on release-3.0

@lzmhhh123 lzmhhh123 changed the title planner: fix bugs and make it more effective in outer join elimination rule. (#11160) Automated cherry pick of #11160 on release-3.0. #11160: fix bug in in outer_join_elimination fix bug address comments fix parentCols when meeting logicalAgg address comments merge two judge cols in outerplan functions address comments add comments for "if len(cols) == 0" address comments address comments rm make slice & use copy instead directly assign fix improve readability reuse the origin buffer address comments planner: fix bugs and make it more effective in outer join elimination rule. (#11160) Jul 23, 2019
@lzmhhh123 lzmhhh123 added sig/planner SIG: Planner priority/release-blocker This issue blocks a release. Please solve it ASAP. type/bugfix This PR fixes a bug. labels Jul 23, 2019
@lzmhhh123
Copy link
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

zz-jason
zz-jason reviewed Jul 24, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 24, 2019
@zz-jason zz-jason requested a review from eurekaka July 24, 2019 11:04
eurekaka
eurekaka approved these changes Jul 28, 2019
View reviewed changes
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason closed this Jul 28, 2019
@zz-jason zz-jason reopened this Jul 28, 2019
@zz-jason
Copy link
Member

/rebuild

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 29, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Jul 29, 2019

/run-all-tests

@sre-bot sre-bot merged commit aede000 into pingcap:release-3.0 Jul 29, 2019
@lzmhhh123 lzmhhh123 deleted the automated-cherry-pick-of-#11160-origin-release-3.0 branch July 29, 2019 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@eurekaka eurekaka eurekaka approved these changes

Assignees
No one assigned
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzmhhh123 @zz-jason @sre-bot @eurekaka