Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: show CARTESIAN Join explicitly in the results of Explain (#11415) #11429

Merged
merged 1 commit into from
Jul 25, 2019
Merged

executor: show CARTESIAN Join explicitly in the results of Explain (#11415) #11429

merged 1 commit into from
Jul 25, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jul 25, 2019 •
edited
Loading

cherry-pick for #11415 .
no conflict.

@qw4990
Copy link
Contributor Author

qw4990 commented Jul 25, 2019

/run-all-tests

alivxxx
alivxxx reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 requested a review from zz-jason July 25, 2019 03:16
zz-jason
zz-jason approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 25, 2019
@zz-jason zz-jason merged commit 37cf597 into pingcap:release-3.0 Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qw4990 @zz-jason @alivxxx