Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv: invalidate store's regions when store be removed in kv (#11567) #11584

Merged
merged 2 commits into from
Aug 2, 2019
Merged

tikv: invalidate store's regions when store be removed in kv (#11567) #11584

merged 2 commits into from
Aug 2, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Aug 2, 2019 •
edited
Loading

cherry-pick #11567 to 3.0

# Conflicts:
#	store/tikv/region_cache.go

This change is Reviewable

@lysu
Copy link
Contributor Author

lysu commented Aug 2, 2019

/run-all-tests

@lysu lysu requested review from jackysp and coocood August 2, 2019 06:49
@coocood
Copy link
Member

coocood commented Aug 2, 2019

LGTM

@lysu lysu added priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2019
jackysp
jackysp approved these changes Aug 2, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/all tests passed status/can-merge Indicates a PR has been approved by a committer. labels Aug 2, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Aug 2, 2019

@lysu merge failed.

@alivxxx
Copy link
Contributor

alivxxx commented Aug 2, 2019

/run-unit-test

@ngaut ngaut merged commit 234a610 into pingcap:release-3.0 Aug 2, 2019
@ngaut ngaut added component/DDL-need-LGT3 status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 2, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp approved these changes

@coocood coocood Awaiting requested review from coocood

Assignees
No one assigned
Labels
component/tikv priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/sql-infra SIG: SQL Infra status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@lysu @coocood @sre-bot @alivxxx @jackysp @ngaut @you06