executor: refine the usage of expression blacklist #11940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11940 +/- ##
================================================
- Coverage 81.3028% 81.2303% -0.0725%
================================================
Files 443 438 -5
Lines 94929 94541 -388
================================================
- Hits 77180 76796 -384
+ Misses 12264 12250 -14
- Partials 5485 5495 +10 |
|
/run-common-test |
qw4990
reviewed
Aug 30, 2019
qw4990
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 in PR #11944 |
XuHuaiyu
added a commit
to XuHuaiyu/tidb
that referenced
this pull request
Sep 2, 2019
sre-bot
pushed a commit
that referenced
this pull request
Sep 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
refine the usage of expression blacklist
What is changed and how it works?
Before this commit, we need to use an alias name to avoid the pushing down of a specific expression.
After this commit, we can use the original name of expression to avoid it.
Check List
Tests
exist tests
Code changes
Side effects
N/A
Related changes
Release note