-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: go generate builtin_control_vec.go #12140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SunRunAway
requested review from
qw4990,
Reminiscent,
zz-jason and
XuHuaiyu
September 10, 2019 12:47
SunRunAway
added
sig/execution
SIG execution
component/expression
and removed
sig/execution
SIG execution
labels
Sep 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #12140 +/- ##
===========================================
Coverage 81.2926% 81.2926%
===========================================
Files 454 454
Lines 98528 98528
===========================================
Hits 80096 80096
Misses 12717 12717
Partials 5715 5715 |
/run-all-tests |
zz-jason
reviewed
Sep 10, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
SunRunAway
force-pushed
the
builtin_control_vec
branch
from
September 10, 2019 16:21
0ac1791
to
8c2c335
Compare
qw4990
approved these changes
Sep 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qw4990
added
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Sep 12, 2019
/run-all-tests |
48 tasks
This was referenced Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
part of #12058
Try to use
go generate
to generate allbuiltinIf{{ .TypeName }}Sig
vector functions in builtin_control_vec.go along with test case and benchmarks.go generate ./...
and check incorrect modification with generated files.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note