Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinIsIPv4Sig #12269

Merged
merged 11 commits into from
Sep 24, 2019
Merged

expression: implement vectorized evaluation for builtinIsIPv4Sig #12269

merged 11 commits into from
Sep 24, 2019

Conversation

k-ye
Copy link
Contributor

@k-ye k-ye commented Sep 18, 2019 •
edited
Loading

What problem does this PR solve?

Implement vectorized evaluation for builtinIsIPv4Sig for #12103.

What is changed and how it works?

According to benchmark, about 3 times faster than before:

BenchmarkVectorizedBuiltinMiscellaneousCasesFunc/builtinIsIPv4Sig-VecBuiltinFunc-4           	  200000	     11449 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinMiscellaneousCasesFunc/builtinIsIPv4Sig-NonVecBuiltinFunc-4        	   50000	     35409 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 18, 2019
@codecov
Copy link

codecov bot commented Sep 18, 2019 •
edited
Loading

Codecov Report

Merging #12269 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12269   +/-   ##
===========================================
  Coverage   81.1037%   81.1037%           
===========================================
  Files           454        454           
  Lines         99210      99210           
===========================================
  Hits          80463      80463           
  Misses        12937      12937           
  Partials       5810       5810

@k-ye k-ye marked this pull request as ready for review September 18, 2019 22:36
Reminiscent
Reminiscent reviewed Sep 23, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 23, 2019
@k-ye k-ye requested a review from zz-jason September 23, 2019 04:12
zz-jason
zz-jason previously approved these changes Sep 23, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 23, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 23, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Sep 23, 2019

@k-ye merge failed.

@zz-jason
Copy link
Member

/rebuild

@k-ye
Copy link
Contributor Author

k-ye commented Sep 24, 2019

Sorry for keep being blocked. I feel like it was because after #12291 , we need to explicitly specify the parameter names when constructing vecExprBenchCase. (Otherwise I got this error message: error: failed to check packages: errors while loading package github.com/pingcap/tidb/expression [github.com/pingcap/tidb/expression.test]: [/Users/yekuang/Repositories/go/src/github.com/pingcap/tidb/expression/builtin_miscellaneous_vec_test.go:29:54: too few values in struct literal])

@k-ye k-ye requested a review from zz-jason September 24, 2019 11:37
@zz-jason
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 24, 2019

/run-all-tests

@sre-bot sre-bot merged commit ba081eb into pingcap:master Sep 24, 2019
@k-ye k-ye deleted the vectorize branch September 24, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@qw4990 qw4990 qw4990 left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@k-ye @CLAassistant @sre-bot @zz-jason @qw4990 @Reminiscent