Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinAbsIntSig #12296

Merged
merged 2 commits into from
Sep 22, 2019

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Sep 22, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinAbsIntSig.
Issue #12103

What is changed and how it works?

BenchmarkVectorizedBuiltinMathFunc/builtinAbsIntSig-VecBuiltinFunc-4              300000              5640 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinMathFunc/builtinAbsIntSig-NonVecBuiltinFunc-4           100000             23146 ns/op               0 B/op          0 allocs/op

Check List

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 22, 2019
@qw4990 qw4990 self-requested a review September 22, 2019 07:14
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Sep 22, 2019

/rebuild

@codecov
Copy link

codecov bot commented Sep 22, 2019

Codecov Report

Merging #12296 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12296   +/-   ##
===========================================
  Coverage   81.1042%   81.1042%           
===========================================
  Files           454        454           
  Lines         98805      98805           
===========================================
  Hits          80135      80135           
  Misses        12896      12896           
  Partials       5774       5774

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SunRunAway SunRunAway added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 22, 2019

/run-all-tests

@sre-bot sre-bot merged commit c94d7a8 into pingcap:master Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants