Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner/core: fix resolve rule for group by expression (#12307) #12351

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 24, 2019

cherry-pick #12307 to release-3.0


What problem does this PR solve?

When there is paramemter markers in group by, it should be only treated as position expression when it is in top level and it is a constant uint.

What is changed and how it works?

Change the resolve rule for group by expressions.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix wrong resolve rule for GroupBy expressions in prepare statemet.

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 24, 2019

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 24, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Sep 24, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 24, 2019

/run-all-tests

@sre-bot sre-bot merged commit 54ddd2c into pingcap:release-3.0 Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants