Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner, executor: push limit down into IndexLookUpReader executor (#12262) #12378

Merged
merged 2 commits into from
Sep 25, 2019

Conversation

eurekaka
Copy link
Contributor

@eurekaka eurekaka commented Sep 25, 2019

Cherry-pick #12262

Conflicts:
cmd/explaintest/r/explain_easy.result
cmd/explaintest/r/explain_easy_stats.result
planner/core/integration_test.go
planner/core/physical_plans.go
planner/core/testdata/plan_suite_out.json

…ingcap#12262)

Conflicts:
	cmd/explaintest/r/explain_easy.result
	cmd/explaintest/r/explain_easy_stats.result
	planner/core/integration_test.go
	planner/core/physical_plans.go
	planner/core/testdata/plan_suite_out.json
@eurekaka eurekaka added type/enhancement The issue or PR belongs to an enhancement. sig/planner SIG: Planner sig/execution SIG execution type/3.0 cherry-pick labels Sep 25, 2019
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 25, 2019
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

/run-all-tests

@zz-jason zz-jason added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Sep 25, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 25, 2019

@eurekaka merge failed.

@zz-jason zz-jason merged commit 3716ac5 into pingcap:release-3.0 Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants