Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement vectorized evaluation for builtinDayOfMonthSig #12409

Merged
merged 7 commits into from
Sep 26, 2019
Merged

implement vectorized evaluation for builtinDayOfMonthSig #12409

merged 7 commits into from
Sep 26, 2019

Conversation

luyunyyyyy
Copy link
Contributor

What problem does this PR solve?

implement vectorized evaluation for builtinDayOfMonthSig
#12103

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinTimeFunc/builtinDayOfMonthSig-VecBuiltinFunc-4                  100000             18583 ns/op               0 B/op          0 allocs/op
BenchmarkVectorizedBuiltinTimeFunc/builtinDayOfMonthSig-NonVecBuiltinFunc-4                30000             43965 ns/op               0 B/op          0 allocs/op

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Sep 26, 2019
@codecov
Copy link

codecov bot commented Sep 26, 2019 •
edited
Loading

Codecov Report

Merging #12409 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12409   +/-   ##
===========================================
  Coverage   79.7039%   79.7039%           
===========================================
  Files           461        461           
  Lines        101621     101621           
===========================================
  Hits          80996      80996           
  Misses        14800      14800           
  Partials       5825       5825

@luyunyyyyy
Copy link
Contributor Author

I‘m sorry to import some useless commit. If need to clean up commit log, please tell me. Thanks.

XuHuaiyu
XuHuaiyu reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2019
qw4990
qw4990 approved these changes Sep 26, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 26, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

Your auto merge job has been accepted, waiting for 11951

@sre-bot
Copy link
Contributor

sre-bot commented Sep 26, 2019

/run-all-tests

@sre-bot sre-bot merged commit 2dc6264 into pingcap:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu left review comments

@qw4990 qw4990 qw4990 approved these changes

@Reminiscent Reminiscent Awaiting requested review from Reminiscent

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luyunyyyyy @sre-bot @qw4990 @XuHuaiyu