Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinArithmeticMultiplyRealSig #12543

Merged
merged 2 commits into from
Oct 8, 2019
Merged

expression: implement vectorized evaluation for builtinArithmeticMultiplyRealSig #12543

merged 2 commits into from
Oct 8, 2019

Conversation

hey-kong
Copy link
Contributor

@hey-kong hey-kong commented Oct 8, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinArithmeticMultiplyRealSig.#12105

What is changed and how it works?

goos: linux
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticMultiplyRealSig-VecBuiltinFunc-4                384745              3277 ns/op            0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticMultiplyRealSig-NonVecBuiltinFunc-4              39608             29081 ns/op            0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusRealSig-VecBuiltinFunc-4                    270891              3777 ns/op            0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticPlusRealSig-NonVecBuiltinFunc-4                  40618             28557 ns/op            0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticMinusRealSig-VecBuiltinFunc-4                   299098              3472 ns/op            0 B/op           0 allocs/op
BenchmarkVectorizedBuiltinArithmeticFunc/builtinArithmeticMinusRealSig-NonVecBuiltinFunc-4                 37515             31396 ns/op            0 B/op           0 allocs/op
PASS
ok      github.com/pingcap/tidb/expression      8.894s

Check List

Tests

  • Unit test

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Oct 8, 2019
@codecov
Copy link

codecov bot commented Oct 8, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@3e8129d). Click here to learn what that means.
The diff coverage is 70%.

@@             Coverage Diff             @@
##             master     #12543   +/-   ##
===========================================
  Coverage          ?   79.8819%           
===========================================
  Files             ?        460           
  Lines             ?     102535           
  Branches          ?          0           
===========================================
  Hits              ?      81907           
  Misses            ?      14678           
  Partials          ?       5950

Reminiscent
Reminiscent reviewed Oct 8, 2019
View reviewed changes
Copy link
Contributor

@Reminiscent Reminiscent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 8, 2019
XuHuaiyu
XuHuaiyu approved these changes Oct 8, 2019
View reviewed changes
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 8, 2019

/run-all-tests

@sre-bot sre-bot merged commit 2865b81 into pingcap:master Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reminiscent Reminiscent Reminiscent left review comments

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

@SunRunAway SunRunAway Awaiting requested review from SunRunAway

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hey-kong @sre-bot @XuHuaiyu @Reminiscent @zz-jason @qw4990