infoschema: add tidb_servers_info memory table #12580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #12580 +/- ##
==========================================
Coverage ? 80.178%
==========================================
Files ? 462
Lines ? 107048
Branches ? 0
==========================================
Hits ? 85829
Misses ? 15094
Partials ? 6125 |
|
/run-all-tests |
AilinKid
reviewed
Oct 11, 2019
AilinKid
reviewed
Oct 11, 2019
djshow832
reviewed
Oct 11, 2019
domain/infosync/info.go
Outdated
| func (is *InfoSyncer) GetAllServerInfo(ctx context.Context) (map[string]*ServerInfo, error) { | ||
| func GetAllServerInfo(ctx context.Context) (map[string]*ServerInfo, error) { | ||
| if globalInfoSyncer == nil { | ||
| return nil, nil |
There was a problem hiding this comment.
If globalInfoSyncer is nil, err shouldn't be nil. Otherwise it would panic when executing serverInfo.IP.
djshow832
reviewed
Oct 11, 2019
djshow832
reviewed
Oct 12, 2019
Co-Authored-By: Arenatlx <[email protected]>
Co-Authored-By: Arenatlx <[email protected]>
|
LGTM |
AilinKid
reviewed
Oct 13, 2019
| @@ -299,8 +300,7 @@ func (s *testSuiteP1) TestAdmin(c *C) { | |||
| // rowOwnerInfos := strings.Split(row.Data[1].GetString(), ",") | |||
| // ownerInfos := strings.Split(ddlInfo.Owner.String(), ",") | |||
| // c.Assert(rowOwnerInfos[0], Equals, ownerInfos[0]) | |||
| do := domain.GetDomain(tk.Se.(sessionctx.Context)) | |||
| serverInfo, err := do.InfoSyncer().GetServerInfoByID(ctx, row.GetString(1)) | |||
| serverInfo, err := infosync.GetServerInfoByID(ctx, row.GetString(1)) | |||
There was a problem hiding this comment.
Cause server info can access in a manner of table, we need other tests for testing SQL on your memory table to prevent code coverage decrease.
There was a problem hiding this comment.
see TestForServersInfo .
|
LGTM |
c4pt0r
approved these changes
Oct 14, 2019
crazycs520
added
status/LGT2
|
/run-all-tests |
qiuyesuifeng
pushed a commit
to qiuyesuifeng/tidb
that referenced
this pull request
Oct 17, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
crazycs520
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Feb 13, 2020
Signed-off-by: crazycs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes