executor: fix data race in GetDirtyTable()
#12767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #12767 +/- ##
===========================================
Coverage 80.0495% 80.0495%
===========================================
Files 465 465
Lines 107326 107326
===========================================
Hits 85914 85914
Misses 14966 14966
Partials 6446 6446 |
eurekaka
reviewed
Oct 22, 2019
zz-jason
changed the title
GetDirtyTable()
alivxxx
reviewed
Oct 23, 2019
| // tables is a map whose key is tableID. | ||
| tables map[int64]*DirtyTable | ||
| } | ||
|
|
||
| // GetDirtyTable gets the DirtyTable by id from the DirtyDB. | ||
| func (udb *DirtyDB) GetDirtyTable(tid int64) *DirtyTable { | ||
| // The index join access the tables map paralelly. | ||
| // But the map throws panic in this case. So it's locked. |
There was a problem hiding this comment.
Could you also update the comment in table reader case of buildUnionScanFromReader? It is outdated now.
…/github.com/lzmhhh123/tidb into bug-fix/dirty_table_map_read_write_conflict
eurekaka
approved these changes
Oct 23, 2019
eurekaka
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.1 failed |
|
cherry pick to release-3.0 failed |
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Oct 23, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Oct 23, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Oct 23, 2019
This was referenced Oct 23, 2019
lfkdsk
added a commit
to JustProject/tidb
that referenced
this pull request
Oct 26, 2019
…ect/tidb into feature-add-udf-support * 'feature-add-udf-support' of https://github.com/JustProject/tidb: (26 commits) *: fix bug that the kill command doesn't work when the killed session is waiting for the pessimistic lock (pingcap#12852) executor: fix the projection upon the indexLookUp in indexLookUpJoin can't get result. (pingcap#12889) planner, executor: support create view on union (pingcap#12595) planner/cascades: introduce TransformationID in cascades planner (pingcap#12879) executor: fix data race in test (pingcap#12910) executor: reuse chunk row for insert on duplicate update (pingcap#12847) ddl: speed up tests (pingcap#12888) executor: speed up test (pingcap#12896) expression: implement vectorized evaluation for `builtinSecondSig` (pingcap#12886) expression: implement vectorized evaluation for `builtinJSONObjectSig` (pingcap#12663) expression: speed up builtinRepeatSig by using MergeNulls (pingcap#12674) expression: speed up unit tests under the expression package (pingcap#12887) store,kv: snapshot doesn't cache the non-exists kv entries lead to poor 'insert ignore' performance (pingcap#12872) executor: fix data race in `GetDirtyTable()` (pingcap#12767) domain: increase TTL to reduce the occurrence of reporting min startTS errors (pingcap#12578) executor: split test for speed up (pingcap#12881) executor: fix inconsistent of grants privileges with MySQL when executing `grant all on ...` (pingcap#12330) expression: implement vectorized evaluation for `builtinJSONUnquoteSig` (pingcap#12841) tune grpc connection count between tidb and tikv (pingcap#12884) Makefile: change test parallel to 8 (pingcap#12885) ...
sre-bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
sre-bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
sre-bot
pushed a commit
that referenced
this pull request
Nov 4, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As the title says.
What is changed and how it works?
Add the lock for dirty DB.
Check List
Tests
Side effects
Related changes