Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: let flush privileges do nothing when skip-grant-table is configured #10986 #12816

Merged
merged 3 commits into from
Oct 21, 2019
Merged

executor: let flush privileges do nothing when skip-grant-table is configured #10986 #12816

merged 3 commits into from
Oct 21, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #10986

@zyxbest
Copy link
Contributor

zyxbest commented Oct 18, 2019

/build

@tiancaiamao
Copy link
Contributor Author

/run-all-tests

jackysp
jackysp reviewed Oct 18, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 18, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @zz-jason

zz-jason
zz-jason approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 21, 2019

Your auto merge job has been accepted, waiting for 12698

@sre-bot
Copy link
Contributor

sre-bot commented Oct 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit 2098cfe into pingcap:release-2.1 Oct 21, 2019
@tiancaiamao tiancaiamao deleted the skip-flush branch May 26, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/privilege status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiancaiamao @zyxbest @sre-bot @jackysp @zz-jason