fix ConvertJSONToInt unsigned bug (#11483) #13036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H-ZeX <[email protected]>
H-ZeX
added
type/2.1 cherry-pick
component/expression
type/bugfix
|
LGTM |
1 similar comment
|
LGTM |
wjhuang2016
approved these changes
Oct 30, 2019
AilinKid
reviewed
Oct 30, 2019
zz-jason
added
status/can-merge
|
/run-all-tests |
|
@H-ZeX merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 13039, 13031, 12960, 12962, 12900, 12901, 12902, 12708, 12707, 12761, 12745, 12975 |
|
/run-unit-test |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #11483 to release 2.1
Signed-off-by: H-ZeX [email protected]
What problem does this PR solve?
The origin
ConvertJSONToIntwill fail in this sqlselect convert(a2.a, unsigned int) from (select cast('"9223372036854775808"' as json) as a) as a2;What is changed and how it works?
call
StrToIntorStrToUintaccording to the paramunsigned.Check List
Tests
Code changes
No
Side effects
No.
Related changes
No.