Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

store: stop updating pessimistic transaction's lock TTL when the session is killed (#12959) #13046

Merged
merged 4 commits into from
Nov 11, 2019
Merged

store: stop updating pessimistic transaction's lock TTL when the session is killed (#12959) #13046

merged 4 commits into from
Nov 11, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #12959

@tiancaiamao tiancaiamao added type/3.0 cherry-pick type/bugfix This PR fixes a bug. component/tikv and removed type/bugfix This PR fixes a bug. labels Oct 31, 2019
@tiancaiamao
Copy link
Contributor Author

PTAL @MyonKeminta @coocood @jackysp

@jackysp jackysp added type/compatibility release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 31, 2019
@jackysp
Copy link
Member

jackysp commented Oct 31, 2019

This PR will bring compatibility issues. The original default value is now in the illegal range. Pay attention to the small version upgrade. @ericsyh

jackysp
jackysp reviewed Oct 31, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood
Copy link
Member

coocood commented Oct 31, 2019

LGTM

@ngaut ngaut removed the status/DNM label Nov 1, 2019
@ngaut ngaut added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 1, 2019
@tiancaiamao tiancaiamao mentioned this pull request Nov 4, 2019
Merged
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

coocood
coocood approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@coocood coocood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coocood coocood merged commit 5b44298 into pingcap:release-3.0 Nov 11, 2019
@tiancaiamao tiancaiamao deleted the cherry-3.0 branch November 11, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@coocood coocood coocood approved these changes

Assignees
No one assigned
Labels
component/tikv release-note Denotes a PR that will be considered when it comes time to generate release notes. status/LGT2 Indicates that a PR has LGTM 2. type/compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tiancaiamao @jackysp @coocood @ngaut @shenli