coprocessor: fix wrong cop task range for tiflash. #13292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zz-jason
reviewed
Nov 8, 2019
|
@zz-jason Tests already changed. |
Codecov Report
@@ Coverage Diff @@
## master #13292 +/- ##
===========================================
Coverage 80.5877% 80.5877%
===========================================
Files 469 469
Lines 113918 113918
===========================================
Hits 91804 91804
Misses 15176 15176
Partials 6938 6938 |
alivxxx
reviewed
Nov 8, 2019
store/tikv/coprocessor.go
Outdated
| @@ -239,7 +249,14 @@ func buildCopTasks(bo *Backoffer, cache *RegionCache, ranges *copRanges, req *kv | |||
| i = nextI | |||
| } | |||
| } else if req.StoreType == kv.TiFlash { | |||
| fullRange := kv.KeyRange{StartKey: regionWithRangeInfo.StartKey, EndKey: regionWithRangeInfo.EndKey} | |||
| left, right := regionWithRangeInfo.StartKey, regionWithRangeInfo.EndKey | |||
| if bytes.Compare(tableStart, left) >= 0 || len(left) == 0 { | |||
There was a problem hiding this comment.
No need to check len(left) because if it is the case, previous check must be true.
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 13251, 13252 |
|
/run-all-tests |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
lzmhhh123
added a commit
to lzmhhh123/tidb
that referenced
this pull request
Jan 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As the title says.
What is changed and how it works?
The full range of a region task is false to set at region full range. But when tidb coprocessor retries requests. It needs to be the table full range in a region. So change the region full range to the table full range in region can fix it.
Check List
Tests
Side effects