planner: projection don't new unnecessary column #13406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
reviewed
Nov 13, 2019
lzmhhh123
reviewed
Nov 13, 2019
ghost
requested review from
wshwsh12 and
XuHuaiyu
and removed request for
a team
winoros
force-pushed
the
dont-new-proj-col
branch
from
21b4bf1
to
3a5dd6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #13406 +/- ##
===========================================
Coverage 80.3292% 80.3292%
===========================================
Files 472 472
Lines 117311 117311
===========================================
Hits 94235 94235
Misses 15837 15837
Partials 7239 7239 |
francis0407
reviewed
Nov 13, 2019
|
/run-unit-test |
lzmhhh123
reviewed
Nov 14, 2019
| @@ -84,10 +73,7 @@ func exprHasSetVarOrSleep(expr expression.Expression) bool { | |||
| // If any expression has SetVar function or Sleep function, we do not prune it. | |||
| func (p *LogicalProjection) PruneColumns(parentUsedCols []*expression.Column) error { | |||
There was a problem hiding this comment.
It seems PruneColumns don't need to return error.
There was a problem hiding this comment.
There's a error check in Aggregation's PruneColumns. In line 113.
winoros
force-pushed
the
dont-new-proj-col
branch
from
a25b90e
to
1064691
Compare
lzmhhh123
added
status/can-merge
|
@winoros merge failed. |
|
/run-all-tests |
|
/run-all-tests tidb-test=pr/950 |
|
/run-common-test tidb-test=pr/950 |
|
/run-common-test tidb-test=pr/950 |
1 similar comment
|
/run-common-test tidb-test=pr/950 |
francis0407
approved these changes
Nov 20, 2019
|
/run-all-tests tidb-test=pr/950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Since name is splitted from the Column.
The project don't need to new column when the expr is just a column.
This makes it possible to merge the two project eliminating process which TiDB current has.
What is changed and how it works?
If the expression is column. We use it directly, instead of new one.
Check List
Tests