executor: refine the check of onlyFullGroupBy when groupByItem is parenthesesExpr or UnaryPlusExpr (#13655) #13658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enthesesExpr or UnaryPlusExpr (pingcap#13655)
XuHuaiyu
added
type/bugfix
|
/run-all-tests |
alivxxx
reviewed
Nov 21, 2019
|
/run-all-tests |
XuHuaiyu
added
status/LGT2
zz-jason
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 14083 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #13655
What problem does this PR solve?
fix issue #13652
What is changed and how it works?
Add the check for ParenthesesExpr and UnaryPlusExpr in checkOnlyFullGroupByWithGroupClause
Check List
Tests
Code changes
Side effects
N/A
Related changes
Release note
Make the check of SQL Mode only_full_group_by correct when the group by items is wrapped with parentheses.