Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: enable 19 functions push down #13683

Merged
merged 3 commits into from
Nov 22, 2019

Conversation

breezewish
Copy link
Member

Signed-off-by: Breezewish [email protected]

What problem does this PR solve?

This PR enables 19 function push down.

What is changed and how it works?

All newly enabled functions have pass randgen test:

tikv/copr-test#45
tikv/copr-test#26
tikv/copr-test#34
tikv/copr-test#43
tikv/copr-test#46
tikv/copr-test#44
tikv/copr-test#37
tikv/copr-test#42
tikv/copr-test#35
tikv/copr-test#54
tikv/copr-test#57
tikv/copr-test#58
tikv/copr-test#66
tikv/copr-test#49
tikv/copr-test#60

Check List

Tests

  • Unit test
  • Integration test

Signed-off-by: Breezewish <[email protected]>
@breezewish breezewish requested a review from a team as a code owner November 22, 2019 07:03
@ghost ghost requested review from SunRunAway and wshwsh12 and removed request for a team November 22, 2019 07:03
Signed-off-by: Breezewish <[email protected]>
@breezewish
Copy link
Member Author

/run-all-tests

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #13683 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13683   +/-   ##
===========================================
  Coverage   79.9955%   79.9955%           
===========================================
  Files           473        473           
  Lines        116204     116204           
===========================================
  Hits          92958      92958           
  Misses        15916      15916           
  Partials       7330       7330

Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. labels Nov 22, 2019
@zz-jason zz-jason changed the title Enable 19 functions push down expression: enable 19 functions push down Nov 22, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 22, 2019

/run-all-tests

@sre-bot sre-bot merged commit 2418958 into pingcap:master Nov 22, 2019
@breezewish breezewish deleted the copr-enable/1122 branch November 22, 2019 09:05
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants