-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: enable 19 functions push down #13683
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <[email protected]>
ghost
requested review from
SunRunAway and
wshwsh12
and removed request for
a team
November 22, 2019 07:03
Signed-off-by: Breezewish <[email protected]>
breezewish
force-pushed
the
copr-enable/1122
branch
from
November 22, 2019 07:07
d1816c5
to
e4b86ce
Compare
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #13683 +/- ##
===========================================
Coverage 79.9955% 79.9955%
===========================================
Files 473 473
Lines 116204 116204
===========================================
Hits 92958 92958
Misses 15916 15916
Partials 7330 7330 |
lonng
reviewed
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
approved these changes
Nov 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
added
component/expression
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
labels
Nov 22, 2019
zz-jason
changed the title
Enable 19 functions push down
expression: enable 19 functions push down
Nov 22, 2019
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/expression
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Breezewish [email protected]
What problem does this PR solve?
This PR enables 19 function push down.
What is changed and how it works?
All newly enabled functions have pass randgen test:
tikv/copr-test#45
tikv/copr-test#26
tikv/copr-test#34
tikv/copr-test#43
tikv/copr-test#46
tikv/copr-test#44
tikv/copr-test#37
tikv/copr-test#42
tikv/copr-test#35
tikv/copr-test#54
tikv/copr-test#57
tikv/copr-test#58
tikv/copr-test#66
tikv/copr-test#49
tikv/copr-test#60
Check List
Tests