ddl: fix index length calculation #13727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangenta
force-pushed
the
index-length-calc
branch
from
c3baceb
to
2b42f90
Compare
Codecov Report
@@ Coverage Diff @@
## master #13727 +/- ##
===========================================
Coverage 80.4209% 80.4209%
===========================================
Files 474 474
Lines 118269 118269
===========================================
Hits 95113 95113
Misses 15740 15740
Partials 7416 7416 |
bb7133
reviewed
Nov 26, 2019
tangenta
force-pushed
the
index-length-calc
branch
from
2b42f90
to
36a6674
Compare
wjhuang2016
reviewed
Nov 26, 2019
wjhuang2016
reviewed
Nov 26, 2019
tangenta
force-pushed
the
index-length-calc
branch
2 times, most recently
from
388ea3f
to
f4df915
Compare
tangenta
force-pushed
the
index-length-calc
branch
from
f4df915
to
de26b1d
Compare
wjhuang2016
reviewed
Nov 26, 2019
tangenta
force-pushed
the
index-length-calc
branch
from
de26b1d
to
ed8e078
Compare
wjhuang2016
added
status/LGT3
tangenta
added
the
status/can-merge
|
/run-all-tests |
|
@tangenta merge failed. |
tangenta
force-pushed
the
index-length-calc
branch
from
df7d3d9
to
4004194
Compare
|
/run-all-tests |
|
/run-common-test -tidb-test=pr/956 |
AilinKid
approved these changes
Nov 26, 2019
|
cherry pick to release-3.0 in PR #13779 |
|
cherry pick to release-2.1 failed |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
This was referenced Mar 2, 2020
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @tangenta PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In MySQL 8.0:
In TiDB master:
The default charset is
utf8mb4with at most 4 bytes per character. However, TiDB assumes 1 byte per character by default, which is incorrect.What is changed and how it works?
getIndexColumnLength, taking charsets into consideration.Check List
Tests
Code changes
N/A
Side effects
Related changes
Release note