Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner/core: raise 'No database selected' error for grant statement (#13745) #13784

Merged
merged 5 commits into from
Dec 6, 2019
Merged

planner/core: raise 'No database selected' error for grant statement (#13745) #13784

merged 5 commits into from
Dec 6, 2019

Conversation

tiancaiamao
Copy link
Contributor

Cherry-pick #13745

@tiancaiamao
Copy link
Contributor Author

PTAL @imtbkcat @lysu

jackysp
jackysp reviewed Nov 28, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from a team December 3, 2019 05:51
@ghost ghost requested review from lzmhhh123 and winoros and removed request for a team December 3, 2019 05:51
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2019
zz-jason
zz-jason approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

@tiancaiamao merge failed.

@winoros winoros removed their request for review December 3, 2019 13:06
@tiancaiamao
Copy link
Contributor Author

/run-all-tests

@tiancaiamao tiancaiamao removed the request for review from lzmhhh123 December 5, 2019 11:19
@jackysp
Copy link
Member

jackysp commented Dec 6, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2019

Your auto merge job has been accepted, waiting for 13892, 13932

@sre-bot
Copy link
Contributor

sre-bot commented Dec 6, 2019

/run-all-tests

@sre-bot sre-bot merged commit c1624d8 into pingcap:release-3.0 Dec 6, 2019
@tiancaiamao tiancaiamao deleted the cherry-13745 branch May 26, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackysp jackysp jackysp left review comments

@zz-jason zz-jason zz-jason approved these changes

Assignees
No one assigned
Labels
component/privilege status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tiancaiamao @sre-bot @jackysp @zz-jason