store/tikv: fix CheckStreamTimeoutLoop goroutine leak #13812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheckStreamTimeoutLoop goroutine is initialized for each connArray, but they're not closed when connArray close, thus leading to the leak
|
/cc @zhangjinpeng1987 |
Codecov Report
@@ Coverage Diff @@
## master #13812 +/- ##
===========================================
Coverage 80.2734% 80.2734%
===========================================
Files 480 480
Lines 119889 119889
===========================================
Hits 96239 96239
Misses 16127 16127
Partials 7523 7523 |
|
LGTM |
lysu
added
status/can-merge
|
/run-all-tests |
|
/run-cherry-picker |
|
cherry pick to release-3.0 failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When the TiKV server close, this goroutine leaks:
In our code, the
CheckStreamTimeoutLoopgoroutine is only closed whenrpcClientclose,but the
rpcClientnever close before the TiDB process exit.What is changed and how it works?
CheckStreamTimeoutLoopgoroutine is initialized for eachconnArray, but they're not closed whenconnArrayclose, thus leading to the leak.Move the
donechannel fromrpcClienttoconnArray, the goroutine would exit whenconnArrayis closed.There is an idle recycle mechanism for the
connArrayto be closed when TiKV server is gone.Check List