Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinLockSig #13880

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

tangwz
Copy link
Contributor

@tangwz tangwz commented Dec 3, 2019

What problem does this PR solve?

Implement vectorized evaluation for builtinLockSig.
Issue: #12103

What is changed and how it works?

The lock function will do nothing.
get_lock() function is parsed but ignored.

Check List

Tests

  • Unit test

@tangwz tangwz requested a review from a team as a code owner December 3, 2019 12:34
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 3, 2019
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team December 3, 2019 12:35
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. labels Dec 3, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 3, 2019

/run-all-tests

@sre-bot sre-bot merged commit 64333ab into pingcap:master Dec 3, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants