*: lock unchanged rows for pessimistic transaction (#14045) #14050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed @coocood |
tiancaiamao
reviewed
Dec 13, 2019
|
|
||
| tk2.Se.GetSessionVars().LockWaitTimeout = 1 | ||
| tk2.MustExec("begin pessimistic") | ||
| err := tk2.ExecToErr("select * from unchanged where id = 1 for update") |
There was a problem hiding this comment.
No, the LockWaitTimeout is set to 1ms, it runs fast.
nowait is not picked to 3.0
There was a problem hiding this comment.
Don't need to pick it for now.
|
LGTM |
|
/merge |
1 similar comment
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #14045 to release-3.0
What problem does this PR solve?
The pessimistic lock is not acquired if a row is unchanged.
What is changed and how it works?
Add the unchanged row key to TxnCtx, later collect them before calling LockKeys.
Check List
Tests
Related changes
Release note