Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support invisible database / table #14069

Closed
wants to merge 1 commit into from

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Dec 16, 2019

What problem does this PR solve?

Support the invisible database/table. e.g.

CREATE TABLE tbl_name (create_definition,...) INVISIBLE
ALTER TABLE tbl_name VISIBLE;

This visible database/table is the normal database/table. This invisible database/table is invisible which means this database/table only can be changed the database/table schema. We only can do alter database/table and drop database/table operation on invisible database/table. In order to know the structure of the invisible database/table, the show create database/table operation is supported on the invisible table.

Relate to pingcap/parser#674
It's used for pingcap/br/issues/87.

What is changed and how it works?

create database/table ... invisible creates a database/table with the state of delete-only.
alter database/table ... visible changes a database/table to public.

Check List

Tests
Unit tests need to be added.

@zimulala zimulala requested a review from a team as a code owner December 16, 2019 06:24
@ghost ghost requested review from eurekaka and winoros and removed request for a team December 16, 2019 06:24
@zimulala
Copy link
Contributor Author

Unit tests need to be added.

@eurekaka eurekaka removed their request for review December 16, 2019 06:26
@zimulala
Copy link
Contributor Author

This feature is not currently required

@zimulala zimulala closed this Dec 18, 2019
@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
@zimulala zimulala deleted the visible-tbl branch March 1, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants