Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcworker: fix potential gcworker goroutine leak during tikv down (#13921) #14106

Merged
merged 3 commits into from
Dec 19, 2019
Merged

gcworker: fix potential gcworker goroutine leak during tikv down (#13921) #14106

merged 3 commits into from
Dec 19, 2019

Conversation

lysu
Copy link
Contributor

@lysu lysu commented Dec 18, 2019 •
edited
Loading

cherry-pick #13921 to 3.0

This change is Reviewable

@lysu lysu requested review from tiancaiamao and MyonKeminta and removed request for tiancaiamao December 18, 2019 03:54
@lysu
Copy link
Contributor Author

lysu commented Dec 18, 2019

/run-all-tests

@lysu
Copy link
Contributor Author

lysu commented Dec 18, 2019

/run-unit-test

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 19, 2019
@lysu lysu requested a review from jackysp December 19, 2019 05:02
zz-jason
zz-jason approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 19, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

Your auto merge job has been accepted, waiting for 14133, 14052, 14132

@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 19, 2019

@lysu merge failed.

@lysu
Copy link
Contributor Author

lysu commented Dec 19, 2019

/run-unit-test

@ngaut ngaut merged commit fda6d3b into pingcap:release-3.0 Dec 19, 2019
@lysu lysu deleted the cp30-gc-infine branch January 3, 2020 07:21
MyonKeminta pushed a commit to MyonKeminta/tidb that referenced this pull request Jun 24, 2020
@lysu @MyonKeminta
gcworker: fix potential gcworker goroutine leak during tikv down (pin…
9cbbd5a 
…gcap#13921) (pingcap#14106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@tiancaiamao tiancaiamao Awaiting requested review from tiancaiamao

@jackysp jackysp Awaiting requested review from jackysp

Assignees
No one assigned
Labels
component/tikv status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lysu @tiancaiamao @sre-bot @zz-jason @ngaut