*: Add binlog prewrite time to record binlog prewrite time consume #14119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
changed the title
|
@jackysp @crazycs520 PTAL |
|
LGTM |
IANTHEREAL
approved these changes
Dec 19, 2019
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-3.0 failed |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
|
It seems that, not for sure, we failed to cherry-pick this commit to release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @cfzjywxk PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Record the
binlogprewrite time consume and log it into the slow query log file, this field could be used to verify if binlog prewrite takes much time intwoPhaseCommiter.executefunctionWhat is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note