executor: avoid ProjectoinExec's goroutine leak
#14127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonng
reviewed
Dec 19, 2019
executor/explain.go
Outdated
| err := Next(ctx, e.analyzeExec, chk) | ||
| if err != nil { | ||
| return nil, err | ||
| next_err = Next(ctx, e.analyzeExec, chk) |
There was a problem hiding this comment.
Please use Golang idiomatic name convention.
winoros
changed the title
EXPLAIN ANALYZE
SunRunAway
reviewed
Dec 19, 2019
executor/explain.go
Outdated
Comment on lines
86
to
101
| close_err = e.analyzeExec.Close() | ||
| if next_err != nil { | ||
| return nil, next_err | ||
| } |
There was a problem hiding this comment.
Is it better?
defer terror.Log(e.analyzeExec.Close())
SunRunAway
reviewed
Dec 19, 2019
fzhedu
force-pushed
the
goroutine-leak
branch
from
bc7de31
to
ca53c94
Compare
SunRunAway
reviewed
Dec 24, 2019
executor/explain.go
Outdated
| @@ -15,6 +15,7 @@ package executor | |||
|
|
|||
| import ( | |||
| "context" | |||
| "github.com/pingcap/errors" | |||
There was a problem hiding this comment.
Please group the import path.
winoros
changed the title
EXPLAIN ANALYZEProjectoinExec's goroutine leak
bb7133
added
the
priority/release-blocker
fzhedu
force-pushed
the
goroutine-leak
branch
from
ca53c94
to
83683ec
Compare
SunRunAway
reviewed
Dec 25, 2019
| if panicErr := recover(); panicErr != nil && !closed { | ||
| err = e.analyzeExec.Close() | ||
| closed = true | ||
| } |
There was a problem hiding this comment.
If you call recover here, the panic will be recovered here, which is not we want.
Suggest just check closed.
defer func() {
// close if panic happens
if !closed { e.analyzeExec.Close() }
}()There was a problem hiding this comment.
if without recover, the goroutine will panic, and test will not work.
fzhedu
force-pushed
the
goroutine-leak
branch
from
6460ad9
to
d090ccc
Compare
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
SunRunAway
added
status/LGT1
|
cherry pick to release-3.0 failed |
|
cherry pick to release-2.1 failed |
This was referenced Dec 25, 2019
zz-jason
pushed a commit
that referenced
this pull request
Dec 25, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #14125
What is changed and how it works?
invoke close() even next() errors in explain statements
Check List
Tests
Code changes
Side effects
Related changes
Release note