-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privilege: fix privilege problem after upgrade #14177
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imtbkcat
added
type/bugfix
This PR fixes a bug.
component/privilege
needs-cherry-pick-3.0
labels
Dec 23, 2019
/run-all-tests |
imtbkcat
force-pushed
the
upgradePrivilege
branch
from
December 23, 2019 04:59
744238e
to
ba83fec
Compare
lysu
reviewed
Dec 23, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
manual tested by this way: use v2.1.18 version:
after upgrade to latest version:
|
LGTM |
tiancaiamao
approved these changes
Dec 23, 2019
imtbkcat
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Dec 23, 2019
/run-all-tests |
cherry pick to release-3.0 failed |
imtbkcat
pushed a commit
to imtbkcat/tidb
that referenced
this pull request
Dec 23, 2019
sre-bot
pushed a commit
that referenced
this pull request
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/privilege
status/can-merge
Indicates a PR has been approved by a committer.
type/bugfix
This PR fixes a bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
There are several privilege problem will occur after upgrade.
What is changed and how it works?
for new privilege, add them reference to MySQL.
for new column which is 'N' originally, set them to 'Y' for user with all privilege.
Check List
Tests
create user t1
(in v3.0.4)grant all on *.* to t1
(in v3.0.4)upgrade to master
show grants for t1
Code changes
Side effects
Related changes
Release note