executor: add lock keys duration metric #14194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cfzjywxk If we remove the check, optimistic transactions are recorded too, we will get too many near-zero values. |
|
We need to store PessimisticLockWaited in StmtContext |
cfzjywxk
force-pushed
the
3_0_lock_wait
branch
from
ece21ce
to
bba781f
Compare
Yes it's needed |
|
LGTM |
|
/run-unit-test |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry-pick #14189 to 3.0
maybe we just record the lock keys duration #14189, record the waited flag and duration in stmtctx(will be used in slow log)
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
tidb-ansiblerepositoryRelease note