Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: keep alive for etcd client #14253

Merged
merged 1 commit into from
Dec 26, 2019
Merged

Conversation

hicqu
Copy link
Contributor

@hicqu hicqu commented Dec 26, 2019

Signed-off-by: qupeng [email protected]

What problem does this PR solve?

Same problem like #14118.

What is changed and how it works?

Add keep alive options for etcd client.

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release note

@hicqu hicqu requested review from lysu and nolouch December 26, 2019 08:49
nolouch
nolouch previously approved these changes Dec 26, 2019
@hicqu
Copy link
Contributor Author

hicqu commented Dec 26, 2019

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 26, 2019
@nolouch nolouch dismissed their stale review December 26, 2019 09:12

not approval

@sre-bot
Copy link
Contributor

sre-bot commented Dec 26, 2019

/run-all-tests

@nolouch
Copy link
Member

nolouch commented Dec 26, 2019

LGTM.

@tiancaiamao
Copy link
Contributor

LGTM

@tiancaiamao tiancaiamao added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 26, 2019
@tiancaiamao
Copy link
Contributor

PTAL @lysu

@hicqu hicqu merged commit 05596fe into pingcap:master Dec 26, 2019
@hicqu hicqu deleted the etcd-client-keep-alive branch December 26, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants