server: add test for /debug/sub-optimal-plan HTTP API
#14302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
|
/run-unit-test |
Deardrops
commented
Jan 2, 2020
| @@ -255,14 +273,8 @@ func (sh *sqlInfoFetcher) getExplainAnalyze(ctx context.Context, sql string, res | |||
| resultChan <- &explainAnalyzeResult{rows: rows} | |||
| } | |||
|
|
|||
| func (sh *sqlInfoFetcher) catchCPUProfile(ctx context.Context, sec int, zw *zip.Writer, errChan chan<- error) { | |||
| // dump profile | |||
| fw, err := zw.Create("profile") | |||
There was a problem hiding this comment.
Call zw.Create("profile") in dumpCPUProfile() instead of catchCPUProfile(),
For avoiding data race with
tidb/server/sql_info_fetcher.go
Line 207 in 5d76de9
AilinKid
reviewed
Jan 2, 2020
reafans
reviewed
Jan 3, 2020
| c.Assert(len(b), Greater, 0) | ||
| c.Assert(resp.Body.Close(), IsNil) | ||
|
|
||
| resp, err = http.PostForm("http://127.0.0.1:10090/debug/sub-optimal-plan?pprof_time=5&timeout=0", urlValues) | ||
| c.Assert(err, IsNil) |
There was a problem hiding this comment.
add more test for pprof_time & timeout & urlValues . like
- only use single pprof_time or single timeout
- set wrong 'curDB'
|
/run-all-tests |
|
Rest LGTM |
|
/run-all-tests |
|
/run-unit-test |
Deardrops
added
status/LGT2
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 14200, 14035, 14275, 14229, 14357 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Improving unit test coverage of
serverpackage.What is changed and how it works?
add test for
/debug/sub-optimal-planHTTP API， This API added by #10717Before this PR:
After this PR：
Check List
Tests
Code changes
Side effects
The test time of
serverpackage increased from 25s to 30s.Related changes
Release note