Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: support to dynamically update some config items read from PD #14393

Closed
wants to merge 21 commits into from

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Jan 8, 2020

What problem does this PR solve?

Part II to implement this proposal: #13660.
Wait for #14303.
In this PR, we refine some code about configs and support to dynamically update some configs items read from PD.

What is changed and how it works?

  1. remove some logic about updating configs online which may result in some conflicts with this feature:
    1.1. remove the feature of hot-reloading configs according to HTTP;
    1.2. forbid to update some config items according to SQL like set @key=val
  2. refine the logic about initializing configs

Check List

Tests

  • Unit test

@qw4990 qw4990 added status/WIP require-LGT3 Indicates that the PR requires three LGTM. component/config labels Jan 8, 2020
@qw4990
Copy link
Contributor Author

qw4990 commented Feb 12, 2020

This PR is too hard to solve these conflicts, so a new PR(#14750) is created to replace this PR.

@qw4990 qw4990 closed this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config require-LGT3 Indicates that the PR requires three LGTM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant