Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store: fix potential panic in GC worker (#14403) #14439

Merged
merged 6 commits into from
Jan 16, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Jan 10, 2020

Conflicts:
store/tikv/gcworker/gc_worker.go
store/tikv/gcworker/gc_worker_test.go

What problem does this PR solve?

Cherry-pick #14403 to release 3.0.

 Conflicts:
	store/tikv/gcworker/gc_worker.go
	store/tikv/gcworker/gc_worker_test.go
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2020
@bb7133 bb7133 added this to the v3.0.10 milestone Jan 15, 2020
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jan 15, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Jan 15, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Jan 15, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Jan 16, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

/run-all-tests

@jackysp jackysp merged commit 50963e7 into pingcap:release-3.0 Jan 16, 2020
@jackysp jackysp deleted the fix_gc_worker_3.0 branch February 27, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/GC status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants