fix issue 108 #146

shenli · 2015-09-14T15:14:14Z

Fix issue: #108
Refactor update.go and support multiple-table syntax.

I change update syntax according to https://dev.mysql.com/doc/refman/5.7/en/update.html. There should be a "SET" in update statement. So some of tidb_test should be changed.

Support multiple-table syntax

Replace hitWhere with WhereRset

Conflicts: parser/parser_test.go

Fix bug in appendRow

siddontang · 2015-09-15T00:07:46Z

parser/parser.y

@@ -656,9 +659,25 @@ Symbol:

 /*******************************************************************************************/
 Assignment:
-	ColumnName eq Expression
+	QualifiedIdent eq Expression


QualifiedIdent contains db.table.columnname or *, you should handle these for error, maybe.

I add some checks. Maybe we will support db.tbl.col in the future.

I think so.

Address comment

qiuyesuifeng · 2015-09-15T02:50:35Z

expression/expressions/assign.go

@@ -21,6 +21,7 @@ import (

 // Assignment is the expression for assignment, like a = 1.
 type Assignment struct {
+	TableName string


Adding one line comment is much better.

Conflicts: parser/parser_test.go

shenli · 2015-09-15T08:13:01Z

Merge with master.
Replace Do with Next in update.go
Address comments

PTAL

siddontang · 2015-09-15T08:18:05Z

plan/plans/join.go

 	row := make([]interface{}, 0, len(prefix)+len(in))
 	row = append(row, prefix...)
 	row = append(row, in...)
+	row = append(row, rks)


now, the row key is still in the end of the row? not in Row struct?

The Do function will be abandoned. In update.go we use Next. @coocood will remove Do() later.

ngaut · 2015-09-15T09:55:14Z

LGTM

fix issue 108

* restore-util: Implement split/scatter (pingcap#274) * implement split/scatter Signed-off-by: 5kbpers <[email protected]> * init test Signed-off-by: 5kbpers <[email protected]> * redesign output/input of the lib Signed-off-by: 5kbpers <[email protected]> * update dependency Signed-off-by: 5kbpers <[email protected]> * add commments and more tests Signed-off-by: 5kbpers <[email protected]> * add ScanRegions interface to Client Signed-off-by: 5kbpers <[email protected]> * fix potential data race Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * Apply suggestions from code review Co-Authored-By: kennytm <[email protected]> * Update pkg/restore-util/client.go Co-Authored-By: kennytm <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * update dependency Signed-off-by: 5kbpers <[email protected]> * resolve conflicts Signed-off-by: 5kbpers <[email protected]> * fix prefix rewrite Signed-off-by: 5kbpers <[email protected]> * add RewriteRule/skip failed scatter region/retry the SplitRegion Signed-off-by: 5kbpers <[email protected]> * fix test Signed-off-by: 5kbpers <[email protected]> * check if region has peer Signed-off-by: 5kbpers <[email protected]> * more logs Signed-off-by: 5kbpers <[email protected]> * restore-util: add split retry interval (pingcap#277) * reset dependencies to release-3.1 * add split retry interval Signed-off-by: 5kbpers <[email protected]> * fix go.sum Signed-off-by: 5kbpers <[email protected]> * restore-util: wait for scatter region sequentially (pingcap#279) * wait for scatter region sequentially Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * restore-util: add on split hook (pingcap#281) * restore-util: add on split hook Signed-off-by: Neil Shen <[email protected]> * Nil check onSplit Co-Authored-By: kennytm <[email protected]> * restore-util: fix returned new region is nil (pingcap#283) * restore-util: fix returned new region is nil Signed-off-by: 5kbpers <[email protected]> * more logs Signed-off-by: 5kbpers <[email protected]> * *: gofmt Signed-off-by: 5kbpers <[email protected]> * Apply suggestions from code review Co-Authored-By: kennytm <[email protected]> * fix log Signed-off-by: 5kbpers <[email protected]> * restore-util: call onSplit on splitByRewriteRules (pingcap#285) Signed-off-by: Neil Shen <[email protected]> * restore-util: fix overlapped error message (pingcap#293) * restore-util: fix overlapped error message Signed-off-by: 5kbpers <[email protected]> * fix log message Signed-off-by: 5kbpers <[email protected]> * reduce error trace Signed-off-by: 5kbpers <[email protected]> * fix test Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * restore-util: log warning when cannot find matched rewrite rule (pingcap#299) * restore-util: add method to set placement rules and store labels (pingcap#301) * restore-util: add method to set placement rules and store labels Signed-off-by: disksing <[email protected]> * minor fix Signed-off-by: disksing <[email protected]> * address comment Signed-off-by: disksing <[email protected]> * add GetPlacementRules Signed-off-by: disksing <[email protected]> * fix test Signed-off-by: disksing <[email protected]> * restore-util: support batch split (pingcap#300) * restore-util: support batch split Signed-off-by: 5kbpers <[email protected]> * go fmt Signed-off-by: 5kbpers <[email protected]> * Apply suggestions from code review Co-Authored-By: kennytm <[email protected]> * address commits Signed-off-by: 5kbpers <[email protected]> * Update pkg/restore-util/split.go Co-Authored-By: kennytm <[email protected]> * add onSplit callback Signed-off-by: 5kbpers <[email protected]> * fix test Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * restore-util: add upper bound time for waiting for scatter (pingcap#305) * restore: fix scatter regions failed Signed-off-by: 5kbpers <[email protected]> * add log Signed-off-by: 5kbpers <[email protected]> * stop waiting for scatter after 3min Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * restore-util: fix wrong url (pingcap#306) Signed-off-by: disksing <[email protected]> * restore-util: add warning about unmatched table id (pingcap#313) * restore-util: support table partition Signed-off-by: 5kbpers <[email protected]> * fix log Signed-off-by: 5kbpers <[email protected]> * warn table id does not match Signed-off-by: 5kbpers <[email protected]> * add unit tests Signed-off-by: 5kbpers <[email protected]> * Apply suggestions from code review Co-Authored-By: Neil Shen <[email protected]> * fix compile error Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * address comments Signed-off-by: 5kbpers <[email protected]> * fix test Signed-off-by: 5kbpers <[email protected]> Co-authored-by: Ian <[email protected]> Co-authored-by: Neil Shen <[email protected]> * *: prune tidb-tools Signed-off-by: Neil Shen <[email protected]> * restore: address linters suggestions Signed-off-by: Neil Shen <[email protected]> * restore: merge restoreutil into restore Signed-off-by: Neil Shen <[email protected]> * address comment Signed-off-by: Neil Shen <[email protected]> Co-authored-by: 5kbpers <[email protected]> Co-authored-by: kennytm <[email protected]> Co-authored-by: disksing <[email protected]> Co-authored-by: Ian <[email protected]>

* export: record location after connection pool established * address comment

shenli added 6 commits September 13, 2015 23:08

*: Refactor update

cb3ef9c

Support multiple-table syntax

stmts: Remove useless code in update

8981ba3

Replace hitWhere with WhereRset

Merge remote-tracking branch 'origin/master' into shenli/issue-108

2b5c33e

Conflicts: parser/parser_test.go

stmts: WIP test multiple table update

a896aa0

plans: Fix bug in join.go

3848a48

Fix bug in appendRow

Merge remote-tracking branch 'origin/master' into shenli/issue-108

b62ef80

siddontang reviewed Sep 15, 2015
View reviewed changes

parser: Check more cases in Assignment

bef3f7f

Address comment

qiuyesuifeng reviewed Sep 15, 2015
View reviewed changes

shenli added 2 commits September 15, 2015 16:04

Merge remote-tracking branch 'origin/master' into shenli/issue-108

bc21691

Conflicts: parser/parser_test.go

stmts: Address comments

70ac9d2

siddontang reviewed Sep 15, 2015
View reviewed changes

expressions: Address comment

59de8ba

ngaut added a commit that referenced this pull request Sep 15, 2015

Merge pull request #146 from pingcap/shenli/issue-108

011fdbf

fix issue 108

ngaut merged commit 011fdbf into master Sep 15, 2015

ngaut deleted the shenli/issue-108 branch September 15, 2015 09:55

shenli mentioned this pull request Sep 15, 2015

Support UPDATE xxx T0 LEFT OUTER JOIN #108

Closed

YuJuncen pushed a commit to YuJuncen/tidb that referenced this pull request Apr 23, 2021

remove changelog and get change logs from release (pingcap#146)

5c69d10

xhebox pushed a commit to xhebox/tidb that referenced this pull request Sep 28, 2021

[parser] parser: implement Restore for Assignment (pingcap#146)

8b2ff97

xhebox pushed a commit to xhebox/tidb that referenced this pull request Oct 8, 2021

[parser] parser: implement Restore for Assignment (pingcap#146)

a55df28

ti-chi-bot pushed a commit that referenced this pull request Oct 9, 2021

[parser] parser: implement Restore for Assignment (#146)

401e924

okJiang pushed a commit to okJiang/tidb that referenced this pull request Oct 19, 2021

export: record location after connection pool established (pingcap#146)

42ac4de

* export: record location after connection pool established * address comment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix issue 108 #146

fix issue 108 #146

shenli commented Sep 14, 2015

siddontang Sep 15, 2015

shenli Sep 15, 2015

siddontang Sep 15, 2015

qiuyesuifeng Sep 15, 2015

shenli commented Sep 15, 2015

siddontang Sep 15, 2015

shenli Sep 15, 2015

ngaut commented Sep 15, 2015

fix issue 108 #146

fix issue 108 #146

Conversation

shenli commented Sep 14, 2015

siddontang Sep 15, 2015

Choose a reason for hiding this comment

shenli Sep 15, 2015

Choose a reason for hiding this comment

siddontang Sep 15, 2015

Choose a reason for hiding this comment

qiuyesuifeng Sep 15, 2015

Choose a reason for hiding this comment

shenli commented Sep 15, 2015

siddontang Sep 15, 2015

Choose a reason for hiding this comment

shenli Sep 15, 2015

Choose a reason for hiding this comment

ngaut commented Sep 15, 2015