Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix random "IsolationRead" fails #14615

Merged
merged 3 commits into from
Feb 5, 2020

Conversation

lzmhhh123
Copy link
Contributor

What problem does this PR solve?

fix #14579

What is changed and how it works?

The server-level config of isolation read affects all tests for different test suites. So I make the testIntegrationSuite unparallel.

Check List

Tests

  • Unit test
  • Integration test

@lzmhhh123 lzmhhh123 added type/bugfix This PR fixes a bug. component/test labels Feb 4, 2020
@lzmhhh123 lzmhhh123 requested a review from a team as a code owner February 4, 2020 04:24
@ghost ghost requested review from eurekaka and francis0407 and removed request for a team February 4, 2020 04:24
@zz-jason
Copy link
Member

zz-jason commented Feb 4, 2020

Would it increase the CI time to longer than 3 minutes?

@lzmhhh123
Copy link
Contributor Author

Would it increase the CI time to longer than 3 minutes?

I think it just increases a little time. Most of the tests in testIntegrationSuite are like explain select ....

@zz-jason
Copy link
Member

zz-jason commented Feb 4, 2020

Would it increase the CI time to longer than 3 minutes?

I think it just increases a little time. Most of the tests in testIntegrationSuite are like explain select ....

OK

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/can-merge Indicates a PR has been approved by a committer. label Feb 5, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

Your auto merge job has been accepted, waiting for 14627, 14627

@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 5, 2020

@lzmhhh123 merge failed.

@lzmhhh123
Copy link
Contributor Author

/run-unit-test

1 similar comment
@lzmhhh123
Copy link
Contributor Author

/run-unit-test

@lzmhhh123 lzmhhh123 merged commit d7654e3 into pingcap:master Feb 5, 2020
@lzmhhh123 lzmhhh123 deleted the bug-fix/14579 branch February 5, 2020 03:30
hsqlu pushed a commit to hsqlu/tidb that referenced this pull request Feb 8, 2020
lzmhhh123 added a commit to lzmhhh123/tidb that referenced this pull request Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: random "IsolationRead" fails in testAnalyzeSuite.TestIndexRead
5 participants