infoschema: migrate dataForTables and dataForPartitions from package infoschema to executor #15034 #15037
#15208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. If your PR get merged, you will be rewarded 50 points. |
ghost
requested review from
SunRunAway and
XuHuaiyu
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15208 +/- ##
===========================================
Coverage 80.5196% 80.5196%
===========================================
Files 503 503
Lines 133776 133776
===========================================
Hits 107716 107716
Misses 17686 17686
Partials 8374 8374 |
|
|
|
/award-point 100 |
|
Update score success, the task will rewarded 100 after merged. |
github-actions
bot
added
sig/sql-infra
|
/run-check_dev_2 |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
Congratulation! You have awarded a badge for usability challenge program! Please fill the form to get your reward! http://tidbcommunity.mikecrm.com/QMCv4QL |
This was referenced Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UCP #15034
UCP #15037
What problem does this PR solve?
migrate
dataForTablesanddataForPartitionsfrom packageinfoschematoexecutorWhat is changed and how it works?
Infoschema contains too much logic for retrieving data, which is confusing, we need to migrate this part to the executor so that infoshema only contains schema information. Detail ref #15034
and #15037
Check List
Tests
Code changes